Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gsys): define syscalls symbols for non-wasm32 targets #3964

Merged
merged 1 commit into from
May 15, 2024

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented May 14, 2024

demo that previously caused linking error on windows: gear-foundation/dapp-template@master...gsys-windows

@StackOverflowExcept1on StackOverflowExcept1on added A4-insubstantial Not too important PR E1-forcenatwin Force CI to run native Windows build in PR E2-forcemacos Force CI to run macOS build in PR labels May 14, 2024
@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team and removed A4-insubstantial Not too important PR labels May 14, 2024
@breathx
Copy link
Member

breathx commented May 15, 2024

@ark0f ptal

@StackOverflowExcept1on StackOverflowExcept1on merged commit 093b365 into master May 15, 2024
12 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/gsys-define-symbols branch May 15, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team E1-forcenatwin Force CI to run native Windows build in PR E2-forcemacos Force CI to run macOS build in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants